[FFmpeg-devel] [PATCH] vc1dsp: Change remaining stride parameters to ptrdiff_t

[Martin Storsjö]

On Tue, 29 Mar 2022, Ben Avison wrote:

> On 29/03/2022 13:44, Martin Storsjö wrote:
>> The existing x86 assembly for loop filters uses the stride as a
>> full register without clearing/sign extending the upper half
>> of the registers on x86_64.
>> 
>> This avoids crashes if the caller would have passed nonzero bits
>> in the previously undefined upper 32 bits of the parameters.
>
> Looks perfectly reasonable to me. I'll hold off making matching changes 
> to my upcoming Arm versions until this gets merged. (My 64-bit Arm 
> versions followed the old prototype and sign-extended the strides from 
> 32 to 64 bits, but that won't be necessary any more.)

Acked by Lynne on irc too - so I pushed it now.

// Martin