[FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: add option to hevc encoder to prioritize speed.

[Rick Kern]

On Sun, May 1, 2022 at 12:12 PM Simone Karin Lehmann <simone at lisanet.de>
wrote:

> Hi,
>
> … I’m so sorry, the patch I recently sent didn’t test the prio_speed bool.
> This corrects it.
>
> I really sorry. :-/
>
> Regards
> Simone
>
Pushed, with some commit message changes. The first line of the commit
message should start with a short topic - in this case
lavc/videotoolboxenc, followed by a brief description. Commit messages
should also be limited to an 80-character width when practical.


>
>
> > Am 01.05.2022 um 20:25 schrieb Richard Kern <kernrj at gmail.com>:
> >
> >
> >
> >> On May 1, 2022, at 1:31 PM, Simone Karin Lehmann <simone at lisanet.de>
> wrote:
> >>
> >> Hi,
> >>
> >> may I kindly ask you to check, if this patch could now be applied?
> > I’ll look at it today.
> >
> >>
> >> Regards
> >> Simone
> >>
> >> Von meinem iPad gesendet
> >>
> >>> Am 25.04.2022 um 22:33 schrieb Simone Karin Lehmann <simone at lisanet.de
> >:
> >>>
> >>> 
> >>>
> >>>>>> Am 25.04.2022 um 21:14 schrieb Rick Kern <kernrj at gmail.com>:
> >>>>>>
> >>>>>>
> >>>>>> { "a53cc", "Use A53 Closed Captions (if available)", OFFSET(a53_cc),
> >>>>>> AV_OPT_TYPE_BOOL, {.i64 = 1}, 0, 1, VE },
> >>>>>> +    { "prio_speed", "prioritize encoding speed",
> OFFSET(prio_speed),
> >>>>>> AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE },
> >>>>>>
> >>>> It might be simpler to make the default value of prio_speed -1, and
> set
> >>>> this property on the encoder session only when it's non-negative.
> Then we
> >>>> won't need to worry about the default value changing for different
> codecs
> >>>> or different OS versions. It could also be moved into COMMON_OPTIONS
> in
> >>>> this case.
> >>>
> >>> oh yes, that’s way better. I didn’t think of that in the first place.
> Thanks for the hint.
> >>>
> >>> Here’s the modified patch
> >>>
> >>> Simone
> >>>
> > <0001-add-options-to-h264-hevc-and-prores-encoders-to-prio.patch>
> >>
> >>>
> >>> _______________________________________________
> >>> ffmpeg-devel mailing list
> >>> ffmpeg-devel at ffmpeg.org
> >>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >>>
> >>> To unsubscribe, visit link above, or email
> >>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> >> _______________________________________________
> >> ffmpeg-devel mailing list
> >> ffmpeg-devel at ffmpeg.org
> >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >>
> >> To unsubscribe, visit link above, or email
> >> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>