[FFmpeg-devel] [RFC] QSV: Introduce min Compile-SDK Version and check for Runtime-Versions instead

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Xiang,
> Haihao
> Sent: Sunday, May 22, 2022 2:25 PM
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [RFC] QSV: Introduce min Compile-SDK Version
> and check for Runtime-Versions instead
> 
> 
> > > -----Original Message-----
> > > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Soft
> > > Works
> > > Sent: Wednesday, January 12, 2022 4:37 AM
> > > To: FFmpeg development discussions and patches <ffmpeg-
> > > devel at ffmpeg.org>
> > > Subject: Re: [FFmpeg-devel] [RFC] QSV: Introduce min Compile-SDK
> > > Version and check for Runtime-Versions instead
> >
> > [..]
> >
> > > > > Question
> > > > >
> > > > > Having both - run-time and compile-time checks all over the code
> > >
> > > is adding
> > > > > a lot of complexity and makes it difficult to maintain and work
> > >
> > > with.
> > > > >
> > > > > Hence, I'm wondering whether we couldn't/shouldn't introduce a
> > >
> > > minimum
> > > > > MSDK compile-time version, for example 1.22, or even later?
> > > > >
> > > > > This would allow simplification of the QSV code in many places
> > >
> > > where run-
> > > > time
> > > > > version checks are actually needed instead.
> > > > >
> > > > > Over time, there have been better and worse MSDK versions, and
> > >
> > > there
> > > > > should still be enough room for choosing, but I don't think
> > >
> > > there's any
> > > > > reason why somebody would still want to compile against some
> > >
> > > really old
> > > > > (e.g. < 1.22) MSDK version.
> > > > >
> > > > > Please share your thoughts on this subject..
> > > >
> > > > I agree we may add a requirement for the minimal compiling version
> > >
> > > in
> > > > configure,
> > > > version 1.28 was released 3 years ago, how about using this version
> > >
> > > as the
> > > > minimal compiling version ?
> > >
> > > I'm fine with 1.28!
> >
> >
> > Are there any objections towards setting 1.28 as a minimum requirement
> > for the MSDK (QSV) compile-time version?
> >
> 
> I submitted https://ffmpeg.org/pipermail/ffmpeg-devel/2022-
> May/296699.html,could you take a look when you have time ?

Hi Haihao,

thanks a lot for taking care of this, I just couldn't find the time
since I had made the suggestion.

I got it merged and going over it now.

sw