[FFmpeg-devel] [PATCH] avcodec/libx264: remove support for x262 MPEG-2 encoder

[Gyan Doshi]

On 2022-05-27 08:46 pm, Kieran Kunhya wrote:
> On Fri, 27 May 2022 at 09:30, Gyan Doshi <ffmpeg at gyani.pro> wrote:
>
>> Support for 'libx262' was added in e56f14659f by merging
>> Libav e1319aa1c1.
>>
>> The Libav commit author believed that "x262 is a subfeature of x264"
>> but this is not the case. Kieran Kuhnya added support for MPEG-2
>> encoding in *his fork* of x264.
>> See https://github.com/kierank/x262/commit/6851000e27
>>
> x262 is a VideoLAN project: https://git.videolan.org/?p=x262.git;a=summary
>
>
>> So there are two issues:
>> 1) Our configure enables libx262 implicitly if libx264 is enabled
>> and a x262 constant is defined in x264.h; this will never be fulfilled
>> with native x264. Users would have to build x262 and use the libx264
>> generated there. Which brings us to the 2nd issue.
>>
> Yes, there was some reason that I forget that meant we couldn't have a
> single binary doing both.
> And mainline x264 will never merge x262.
>
>
>> 2) Development on the x262 repo stopped in 2015. So, it's likely API
>> and ABI incompatible with native x264 and thus our current wrapper.
>>
> x262 works fine irrespective of lack of development. MPEG-2 came out in
> 1993 after all.

By development, I mean you merging updates to native x264 into your 
repo. That stopped in 2015. So, your repo only supports one bit-depth in 
a build, right?

Regards,
Gyan