[FFmpeg-devel] [PATCH v2 0/3] Some small ASS conversion fixes

[Oneric]

On Sun, Nov 13, 2022 at 21:01:34 +0000, Soft Works wrote:
> I am unable to apply any of those patches. Neither v1 nor v2 neither
> when downloading the series mbox or [2/3] from patchwork nor when
> saving [2/3] from the e-mail.

Re patchwork, yes I rechecked and it appears all downloads are now broken
(see prev message). Regarding applying the mails, all I can say is it
works for me.
After a fresh clone to /tmp/ffmpeg, I can successfully apply v1 1/3, v1 2/3
and v1 3/3 from my mail client via pipe-menu and `git -C /tmp/ffmpeg am -`.
For v2 the first two patches also work.

> Did you notice that FATE has failed, even with the v1 patches?

While checking the current mbox download, I noticed yeah.
The error for loongarch doesn't make sense to me "could not build fake
ancestor" and the x86 runner manages to apply it, so this seems like a
false positive.

For x86_make_fate the short errors snippet that’s available only shows
tests failing which work for me. To make sure, I copied my old fate-suite
dir to the fresh clone, configured with
  --enable-libass --enable-libx264 --enable-libopus
  --enable-gpl --disable-shared --enable-static --samples=fate-suite/
and then ran `make fate-rsync`, `make` and `make fate`
with an appropriate job count for:

 - v2 1+2
 - v2 1+2 followed by v1 3
 - v1 1+2+3

all applied from the received mails and all succeeded.
I’d guess the fate runner uses --no-keep-cr, but then applying should
already fail. Perhaps there’s a similar option only "normalising" added
lines?

Checking the format-patch for v2 3/3 I attached earlier (which also only
ended up as quoted-printable not base64), shows the list again stripped
CRLF just like for the initial patch :(
It appears this list’s configuration is particular bad for CRLF-requiring
patches. (But v1 or forcing base64 should still work)

To make applying easier for you, I now attached all patches bundled as an
archive to keep the list from interfering. Make sure to use --keep-cr.

All tests were done on top of 2d25f33a7ed36003de9a62c9cb165db183663d1c.

Regards
Oneric
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patches_ffmpeg_ass-fixes_20221112.tar.xz
Type: application/x-xz
Size: 3816 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20221113/1677b153/attachment.xz>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20221113/1677b153/attachment.sig>