[FFmpeg-devel] [FFmpeg-cvslog] avformat/mxfenc: reject unsupported ffv1 versions

[Moritz Barsnick]

On Wed, Apr 05, 2023 at 22:50:43 +0000, Jerome Martinez wrote:
> ffmpeg | branch: master | Jerome Martinez <jerome at mediaarea.net> | Tue Apr  4 16:57:03 2023 +0200| [feeeefc3db04810286cd647f235ced0ec6c3eba8] | committer: Michael Niedermayer
>
> avformat/mxfenc: reject unsupported ffv1 versions
>
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
>
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=feeeefc3db04810286cd647f235ced0ec6c3eba8
> ---
>
>  libavformat/mxfenc.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> index 9eba208ffb..d8252ed68f 100644
> --- a/libavformat/mxfenc.c
> +++ b/libavformat/mxfenc.c
> @@ -2493,6 +2493,10 @@ static int mxf_parse_ffv1_frame(AVFormatContext *s, AVStream *st, AVPacket *pkt)
>          if (v > 4) {
>              return 0;
>          }
> +        if (v > 4) {
> +            av_log(s, AV_LOG_ERROR, "unsupported ffv1 version %d\n", v);
> +            return 0;
> +        }
>          sc->micro_version = get_ffv1_unsigned_symbol(&c, state);

You inserted unreachable code.

Cheers,
Moritz