[FFmpeg-devel] [PATCH v2] fftools/ffmpeg_mux: fix reporting muxer EOF as error

[Anton Khirnov]

Quoting Marton Balint (2023-04-24 11:09:44)
> 
> 
> On Sun, 23 Apr 2023, Anton Khirnov wrote:
> 
> > Quoting Marton Balint (2023-04-23 20:15:13)
> >>
> >>
> >> On Sun, 23 Apr 2023, Anton Khirnov wrote:
> >> I don't understand. A good program propagates back error conditions to the
> >> user, and not hides them silently.
> >
> > I do not think blanket claims such as this are a good idea. What is or
> > is not considered "an error condition" depends on the context.
> >
> > As I said before - I don't see why a muxer should ever return
> > AVERROR_EOF to signal a legitimate muxing error.
> 
> The real risk is that they unintentionally do that, when the error code is 
> coming from some underlying operation for example.
> 
> So previsouly a muxer could return any error code to signal error 
> condition and reasonably assume that ffmpeg.c will report it back to the 
> user as an error.

Also, muxers absolutely must not make any assumptions about ffmpeg CLI
behavior, because other callers exist and they must all be treated
equally.

-- 
Anton Khirnov