[FFmpeg-devel] [PATCH v1] avcodec/av1dec: Add tile list OBU to decompose list

[Wang, Fei W]

On Wed, 2023-12-20 at 17:11 +0100, Andreas Rheinhardt wrote:
> fei.w.wang-at-intel.com at ffmpeg.org:
> > From: Fei Wang <fei.w.wang at intel.com>
> > 
> > Show the unsupported message and return unsupported for clips
> > contain
> > tile list OBU since it hasn't been implemented. Otherwise, decoding
> > maybe successful but result is incorrect.
> > 
> > Signed-off-by: Fei Wang <fei.w.wang at intel.com>
> > ---
> >  libavcodec/av1dec.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
> > index 4dcde234c6..629e37c3f8 100644
> > --- a/libavcodec/av1dec.c
> > +++ b/libavcodec/av1dec.c
> > @@ -805,6 +805,7 @@ static const CodedBitstreamUnitType
> > decompose_unit_types[] = {
> >      AV1_OBU_SEQUENCE_HEADER,
> >      AV1_OBU_TEMPORAL_DELIMITER,
> >      AV1_OBU_TILE_GROUP,
> > +    AV1_OBU_TILE_LIST,
> 
> What do you need this for? Decomposing it would only change whether
> CodedBitstreamUnit.content is available, but you are only reading
> CodedBitstreamUnit.type.

To show the unsupported error and let user know that there are tile
list OBUs in bitstream that decoder can't handle them. Otherwise, like
my commit mentioned, tile list obu bitsteam may be decoded 'successful'
according to log.

> 
> >  };
> >  
> >  static av_cold int av1_decode_init(AVCodecContext *avctx)
> > @@ -1327,6 +1328,10 @@ static int
> > av1_receive_frame_internal(AVCodecContext *avctx, AVFrame *frame)
> >              }
> >              break;
> >          case AV1_OBU_TILE_LIST:
> > +            av_log(avctx, AV_LOG_ERROR, "Large scale tile decoding
> > is unsupported.\n");
> > +            ret = AVERROR_PATCHWELCOME;
> > +            goto end;
> > +            break;
> >          case AV1_OBU_TEMPORAL_DELIMITER:
> >          case AV1_OBU_PADDING:
> >              break;
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".