[FFmpeg-devel] [PATCH 3/3] avutil/hwcontext_d3d12va: remove unused variables

Martin Storsjö martin at martin.st
Thu Dec 21 14:42:36 EET 2023


On Thu, 21 Dec 2023, James Almer wrote:

> Removes -Wunused-variable warnings.
>
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
> Were this meant to be used? Or are just a remnant of a previous interation of
> the set?
>
> libavutil/hwcontext_d3d12va.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/libavutil/hwcontext_d3d12va.c b/libavutil/hwcontext_d3d12va.c
> index 4ce29f250c..46832fd19b 100644
> --- a/libavutil/hwcontext_d3d12va.c
> +++ b/libavutil/hwcontext_d3d12va.c
> @@ -173,7 +173,6 @@ fail:
>
> static void d3d12va_frames_uninit(AVHWFramesContext *ctx)
> {
> -    AVD3D12VAFramesContext *frames_hwctx = ctx->hwctx;
>     D3D12VAFramesContext   *s            = ctx->internal->priv;

Here, I'd prefer to get rid of the extra spaces once the other line, which 
it was aligned to, is gone.

> static int d3d12va_frames_init(AVHWFramesContext *ctx)
> {
>     AVD3D12VAFramesContext *hwctx        = ctx->hwctx;
> -    AVD3D12VADeviceContext *device_hwctx = ctx->device_ctx->hwctx;
> -    D3D12VAFramesContext   *s            = ctx->internal->priv;

Ditto

// Martin



More information about the ffmpeg-devel mailing list