[FFmpeg-devel] [PATCH 3/6] checkasm/takdsp: add decorrelate_sm test
Martin Storsjö
martin at martin.st
Fri Dec 22 11:49:39 EET 2023
On Mon, 18 Dec 2023, flow gg wrote:
>
> +static void test_decorrelate_sm(TAKDSPContext *s) {
> +#define BUF_SIZE 1024
> + declare_func(void, int32_t *, int32_t *, int);
> +
> + if (check_func(s->decorrelate_sm, "decorrelate_sm")) {
> + LOCAL_ALIGNED_32(int32_t, p1, [BUF_SIZE]);
> + LOCAL_ALIGNED_32(int32_t, p1_2, [BUF_SIZE]);
> + LOCAL_ALIGNED_32(int32_t, p2, [BUF_SIZE]);
> + LOCAL_ALIGNED_32(int32_t, p2_2, [BUF_SIZE]);
> +
> + randomize(p1, BUF_SIZE);
> + memcpy(p1, p1_2, BUF_SIZE);
p1 is the one that is filled with initialized data here, not the other way
around. Clang optimizes out this memcpy since it's copying uninitialized
data.
> + randomize(p2, BUF_SIZE);
> + memcpy(p2_2, p2, BUF_SIZE);
> +
> + call_ref(p1, p2, BUF_SIZE);
> + call_new(p1_2, p2_2, BUF_SIZE);
> +
> + if (memcmp(p2, p2_2, BUF_SIZE) != 0){
As this function mutates both p1 and p2, we need to check both of them.
Also *sizeof().
// Martin
More information about the ffmpeg-devel
mailing list