[FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

[Rémi Denis-Courmont]

Le perjantaina 22. joulukuuta 2023, 18.13.51 EET Andreas Rheinhardt a écrit :
> Rémi Denis-Courmont:
> > Le perjantaina 22. joulukuuta 2023, 15.48.45 EET Andreas Rheinhardt a 
écrit :
> >> Avoids relocations.
> > 
> > This is a little bit misleading. It reduces the number of relocations
> > indeed, but the data structures still end up in nonshareable .data.relro
> > rather than .rodata due to other remaining pointers.
> 
> I never claimed that the AVClasses would be moved to .rodata. I only
> claimed that it avoids relocations. And it does.

It is misleading because it can be interpreted both ways. I could equally 
argue that it does not avoid relocations: the concerned objects are still 
subject to relocations.

-- 
Rémi Denis-Courmont
http://www.remlab.net/