[FFmpeg-devel] [PATCH v2 0/2] PNG cICP improvements
Leo Izen
leo.izen at gmail.com
Wed Feb 1 19:44:10 EET 2023
The first patch fixes a FATE issue with cICP and iCCP.
The second patch was discussed on IRC. I got a LGTM from Kasper, but sending to ML here and applying in a few days if there's no objections.
A few things discussed:
1) There's no need to expose the gamma table as another function as it's only used here.
2) This patch includes the patch on the ML sent as "avcodec/pngdec: warn when reading tv-range cICP chunks" which got a LGTM from Lynne on IRC. If this is applied that one has no need to be applied.
Changes from v1:
- The second patch broke FATE because I didn't change the fate ref to accommodate the new metadata. I've since updated the fate reference.
Leo Izen (2):
avcodec/pngenc.c: avoid writing cICP when inappropriate
avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL
libavcodec/pngdec.c | 126 +++++++++++++++++++++--------------
libavcodec/pngenc.c | 21 ++++--
tests/ref/fate/png-icc | 8 +--
tests/ref/fate/png-side-data | 2 +-
4 files changed, 94 insertions(+), 63 deletions(-)
--
2.39.1
More information about the ffmpeg-devel
mailing list