[FFmpeg-devel] [PATCH v2 2/2] avformat/flvenc: add option to read metadata from file

[Gyan Doshi]

On 2023-02-09 09:15 pm, Anton Khirnov wrote:
> Quoting Gyan Doshi (2023-02-05 12:05:19)
>>
>> On 2023-02-05 04:07 pm, Anton Khirnov wrote:
>>> Quoting Gyan Doshi (2023-02-04 11:11:12)
>>>> On 2023-02-03 09:04 pm, Andreas Rheinhardt wrote:
>>>>> What does this achieve that can't be achieved by other means (namely by
>>>>> an API-user updating the relevant metadata dictionaries)?
>>>> This option together with meta_period is for CLI users.
>>> Options for CLI users should be in the CLI, not the libraries.
>> Do I then add and use a AVFMT flag to avoid recurring metadata updates
>> for all other muxers?
> I don't follow, why should there be a lavf flag for an ffmpeg CLI
> option?

The meta period option will control how frequently the metadata file is 
read and the muxer ctx dict updated in ffttools write_packet.
Only one muxer - flvenc - can be triggered to recheck the dict in its 
.write_packet, so it seems wasteful to carry out those ops generally.
The AVFMT flag can guard that.

Regards,
Gyan