[FFmpeg-devel] [PATCH v3 1/4] avcodec/bswapdsp: remove unused cextern

[Rémi Denis-Courmont]

Le keskiviikkona 11. tammikuuta 2023, 0.57.13 EET Mark Reid a écrit :
> > Are you really duplicating a whole bunch of files from lavc in sws? I
> > don't think that's anywhere remotely close to acceptable.
> 
> This was what I was suggested to do
> http://ffmpeg.org/pipermail/ffmpeg-devel/2022-December/304667.html

TBH, you do not need to duplicate the source to have the same code statically 
linked in two different libraries. At most, you need some macro to rename the 
functions to avoid duplicate symbols in the odd case that swscale and lavc are 
statically linked into the same shared object. (I do not personally like that 
coding style, but it seems quite popular in FFmpeg already.)

I agree with Anton that duplicating the complete source does not seem 
acceptable (especially if *I* am expected to fix the RISC-V afterwards, but I 
digress).

-- 
Реми Дёни-Курмон
http://www.remlab.net/