[FFmpeg-devel] [PATCH] Add SMC vsynth tests

[Paul B Mahol]

On Sun, Jul 2, 2023 at 6:39 PM Tomas Härdin <git at haerdin.se> wrote:

> sön 2023-07-02 klockan 18:36 +0200 skrev Tomas Härdin:
> > sön 2023-07-02 klockan 12:49 -0300 skrev James Almer:
> > > On 7/2/2023 12:28 PM, Tomas Härdin wrote:
> > > >
> > > > ---
> > > >  tests/fate/vcodec.mak            | 3 +++
> > > >  tests/ref/vsynth/vsynth1-smc     | 4 ++++
> > > >  tests/ref/vsynth/vsynth2-smc     | 4 ++++
> > > >  tests/ref/vsynth/vsynth3-smc     | 4 ++++
> > > >  tests/ref/vsynth/vsynth_lena-smc | 4 ++++
> > > >  5 files changed, 19 insertions(+)
> > > >  create mode 100644 tests/ref/vsynth/vsynth1-smc
> > > >  create mode 100644 tests/ref/vsynth/vsynth2-smc
> > > >  create mode 100644 tests/ref/vsynth/vsynth3-smc
> > > >  create mode 100644 tests/ref/vsynth/vsynth_lena-smc
> > > >
> > > > diff --git a/tests/fate/vcodec.mak b/tests/fate/vcodec.mak
> > > > index ef8904613a..833dde86ab 100644
> > > > --- a/tests/fate/vcodec.mak
> > > > +++ b/tests/fate/vcodec.mak
> > > > @@ -404,6 +404,9 @@ FATE_VCODEC-$(call ENCDEC, RV20, RM)    +=
> > > > rv20
> > > >  fate-vsynth%-rv20:               ENCOPTS = -qscale 10
> > > >  fate-vsynth%-rv20:               FMT     = rm
> > > >
> > > > +FATE_VCODEC_SCALE-$(call ENCDEC, SMC, MOV) += smc
> > > > +fate-vsynth%-smc:                CODEC   = smc
> > >
> > > Missing a FMT = mp4 line (or mov if smc is supported in it).
> >
> > It already says MOV in the call, and mp4 doesn't support SMC
>
> Oh wait the MOV is just for deps I guess, not the actual format output.
> Updated patch attached
>

LGTM
Feel free to push if it passes tests.


>
> /Tomas
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>