[FFmpeg-devel] [PATCH 4/7] checkasm: use pointers for start/stop functions

[Lynne]

Jul 14, 2023, 20:29 by remi at remlab.net:

> This makes all calls to the bench start and stop functions via
> function pointers. While the primary goal is to support run-time
> selection of the performance measurement back-end in later commits,
> this has the side benefit of containing platform dependencies in to
> checkasm.c and out of checkasm.h.
> ---
>  tests/checkasm/checkasm.c | 33 ++++++++++++++++++++++++++++-----
>  tests/checkasm/checkasm.h | 31 ++++---------------------------
>  2 files changed, 32 insertions(+), 32 deletions(-)
>

Not sure I agree with this commit, the overhead can be detectable,
and we have a lot of small functions with runtime a few times that
of a null function call.
Can you store the function pointers out of the loop to reduce
the derefs needed?