[FFmpeg-devel] [PATCH] lavc/audiotoolbox: fix build failure on osx 10.5

[Pavel Koshevoy]

On Fri, Jul 14, 2023 at 7:34 PM James Almer <jamrial at gmail.com> wrote:

> On 7/11/2023 11:10 AM, Pavel Koshevoy wrote:
> > ---
> >   libavcodec/audiotoolboxdec.c | 2 ++
> >   libavcodec/audiotoolboxenc.c | 4 ++++
> >   2 files changed, 6 insertions(+)
> >
> > diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c
> > index 82babe3d31..7b33cdf87d 100644
> > --- a/libavcodec/audiotoolboxdec.c
> > +++ b/libavcodec/audiotoolboxdec.c
> > @@ -71,10 +71,12 @@ static UInt32 ffat_get_format_id(enum AVCodecID
> codec, int profile)
> >           return kAudioFormatAMR;
> >       case AV_CODEC_ID_EAC3:
> >           return kAudioFormatEnhancedAC3;
> > +#if __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ > 1058
>
> Wouldn't it be better to do >= with the actual version where all this is
> first available?
>


I suppose... I've submitted a 2nd version of the patch.

Thank you,
    Pavel.