[FFmpeg-devel] [RFC] [PATCH] avcodec/codec_par: Keep format channel layout if specified

[Anton Khirnov]

Quoting Vittorio Giovara
> 
> Any comments on this patch? If no objections I'd like to push it at the end
> of the week

Sorry, not acceptable. This is the wrong place to do it.

AVCodecParameters is a dumb container for parameters. It MUST NOT make
any assumptions about who calls it or for what purpose. The caller tells
it to copy data - it copies data.

Sadly I don't have the time to think about this in depth right now (ask
me again in 3 weeks or so), but some potential alternatives:
* handle this explicitly in the caller
* add a new function, say avcodec_parameters_update(), perhaps with a
  flags parameter controlling how exactly is the update to be performed;
  not entirely sure this generalizes well enough

-- 
Anton Khirnov