[FFmpeg-devel] [PATCH v3] avformat/flvdec: move read fourcc output before flv_same_video_codec

[Hendrik Leppkes]

On Sat, Jul 29, 2023 at 11:54 AM Hendrik Leppkes <h.leppkes at gmail.com> wrote:
>
> On Sat, Jul 29, 2023 at 10:46 AM Marton Balint <cus at passwd.hu> wrote:
> >
> >
> >
> > On Sat, 29 Jul 2023, Hendrik Leppkes wrote:
> >
> > > On Sat, Jul 29, 2023 at 2:26 AM Steven Liu <lq at chinaffmpeg.org> wrote:
> > >>
> > >> read fourcc for video codec after VideoTagHeader read.
> > >> passed as parameter to flv_same_video_codec.
> > >>
> > >
> > > Add the same parameter to flv_set_video_codec, and then you can remove
> > > the entire backwards seek and just read it and adjust the size like
> > > all other parameters.
> >
> > As far as I see flv_set_video_codec should not read a binary fourcc in the
> > first place when it is called from amf_parse_object.
>
> Yeah probably not, so moving it to a parameter would fix that as well,
> and make the entire parsing flow less opaque.
>

In fact the actual value will carry the FourCC then, which is not
handled at all. Definitely very broken here.

- Hendrik