[FFmpeg-devel] [PATCH] avfilter/avfiltergraph: fix illogical flaws in code

[James Almer]

On 5/12/2023 5:49 PM, Paul B Mahol wrote:
> Attached.

> From 11907ee612b0440faeb3804e8f9af5e36a63db89 Mon Sep 17 00:00:00 2001
> From: Paul B Mahol <onemda at gmail.com>
> Date: Fri, 12 May 2023 21:01:41 +0200
> Subject: [PATCH] avfilter/avfiltergraph: fix illogical flaws in code
> 
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
>  libavfilter/avfiltergraph.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c
> index 53f468494d..744f480e1d 100644
> --- a/libavfilter/avfiltergraph.c
> +++ b/libavfilter/avfiltergraph.c
> @@ -748,8 +748,10 @@ static int reduce_formats_on_filter(AVFilterContext *filter)
>                  (KNOWN(fmt) || fmts->all_counts)) {
>                  /* Turn the infinite list into a singleton */
>                  fmts->all_layouts = fmts->all_counts  = 0;
> -                if (ff_add_channel_layout(&outlink->incfg.channel_layouts, fmt) < 0)
> -                    ret = 1;
> +                ret = ff_add_channel_layout(&outlink->incfg.channel_layouts, fmt);
> +                if (ret < 0)
> +                    return ret;
> +                ret = 1;
>                  break;
>              }

Probably ok.