[FFmpeg-devel] [PATCH] avfilter/src_movie: activate & dr

[James Almer]

On 5/22/2023 11:55 AM, James Almer wrote:
> On 5/22/2023 11:48 AM, Anton Khirnov wrote:
>> Quoting Paul B Mahol (2023-05-18 12:22:07)
>>>  From af73b69a0be9033fddf222b6e9ac60799de85691 Mon Sep 17 00:00:00 2001
>>> From: Paul B Mahol <onemda at gmail.com>
>>> Date: Mon, 15 May 2023 21:54:25 +0200
>>> Subject: [PATCH 26/27] avfilter/src_movie: dr support
>>>
>>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>>> ---
>>>   libavfilter/src_movie.c | 44 +++++++++++++++++++++++++++++++++++++++--
>>>   1 file changed, 42 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/libavfilter/src_movie.c b/libavfilter/src_movie.c
>>> index 5937613d13..a2ecc5a625 100644
>>> --- a/libavfilter/src_movie.c
>>> +++ b/libavfilter/src_movie.c
>>> @@ -23,7 +23,6 @@
>>>    * @file
>>>    * movie video source
>>>    *
>>> - * @todo use direct rendering (no allocation of a new frame)
>>>    * @todo support a PTS correction mechanism
>>>    */
>>> @@ -156,6 +155,43 @@ static AVStream *find_stream(void *log, 
>>> AVFormatContext *avf, const char *spec)
>>>       return found;
>>>   }
>>> +static int get_buffer(AVCodecContext *avctx, AVFrame *frame, int flags)
>>> +{
>>> +    int linesize_align[AV_NUM_DATA_POINTERS];
>>> +    AVFilterLink *outlink = frame->opaque;
>>
>> This is not guaranteed to be set. Use AVCodecContext.opaque instead.
> 
> How so? He set the AV_CODEC_FLAG_COPY_OPAQUE flag and the pkt.opaque 
> field before calling avcodec_send_packet().

Oh, i see now reading the doxy for the flag.