[FFmpeg-devel] [PATCH 03/11] avformat/avformat: use the side data from AVStream.codecpar

[Anton Khirnov]

Quoting James Almer (2023-09-27 15:12:34)
> @@ -807,11 +808,14 @@ static int mov_read_dac3(MOVContext *c, AVIOContext *pb, MOVAtom atom)
>          return 0;
>      st = c->fc->streams[c->fc->nb_streams-1];
>  
> -    ast = (enum AVAudioServiceType*)av_stream_new_side_data(st, AV_PKT_DATA_AUDIO_SERVICE_TYPE,
> -                                                            sizeof(*ast));
> -    if (!ast)
> +    sd = av_packet_side_data_new(&st->codecpar->side_data,
> +                                 &st->codecpar->nb_side_data,
> +                                     AV_PKT_DATA_AUDIO_SERVICE_TYPE,
> +                                     sizeof(*ast), 0);

Weird indentation. Also below.

Overall looks very good to me.


-- 
Anton Khirnov