[FFmpeg-devel] PATCH] Make H.274 film grain support optional for H.264. Saves ~779kb.

Hendrik Leppkes h.leppkes at gmail.com
Tue Aug 13 23:10:52 EEST 2024


On Tue, Aug 13, 2024 at 9:32 PM Dale Curtis <dalecurtis at chromium.org> wrote:
>
> Film grain support adds a huge amount of overhead to the H264Context
> structure for a feature that is rarely used. On low end devices or
> pages that have lots of media this bloats memory usage rapidly.
>
> This introduces a --disable-h264-film-grain option which makes
> these fields optional and reduces the H264Context size from
> 851808 bytes to 53444 bytes.
>
> Bug: https://crbug.com/359358875
> Signed-off-by: Dale Curtis <dalecurtis at chromium.org>
>

Disabling random codec features seems like an anti-feature to me, in
the future it'll make every feature be questioned and compile-time
conditional, and make everything terrible.
If the context size is the major concern, maybe large structures
should be allocated when in use, rather than always?

- Hendrik


More information about the ffmpeg-devel mailing list