[FFmpeg-devel] [PATCH] fftools/ffmpeg: remove useless error check

Anton Khirnov anton at khirnov.net
Wed Aug 14 14:59:40 EEST 2024


Quoting Marvin Scholz (2024-08-13 20:06:42)
> When ret is checked here, it was never assigned anything, making this
> check useless, as highlighted by Coverity.
> 
> It seems to be a copy paste mistake given that opt_match_per_stream_str
> does not return an error code that could be checked and the previous
> value assigned to ret is already checked above. So just remove this
> check.
> 
> Fixes: CID1616292
> ---
>  fftools/ffmpeg_mux_init.c | 2 --
>  1 file changed, 2 deletions(-)

LGTM

Thanks,
-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list