[FFmpeg-devel] [PATCH 2/7] avcodec/aarch64/mpegvideoencdsp: add neon implementations for pix_sum and pix_norm1

Rémi Denis-Courmont remi at remlab.net
Mon Aug 19 08:24:04 EEST 2024


Le 18 août 2024 23:13:21 GMT+03:00, Ramiro Polla <ramiro.polla at gmail.com> a écrit :
>                   A53             A76
>pix_norm1_c:     519.2           231.5
>pix_norm1_neon:  195.0 ( 2.66x)   44.2 ( 5.24x)
>pix_sum_c:       344.5           242.2
>pix_sum_neon:    119.0 ( 2.89x)   41.7 ( 5.81x)
>---
> libavcodec/aarch64/Makefile               |  2 +
> libavcodec/aarch64/mpegvideoencdsp_init.c | 39 +++++++++++++
> libavcodec/aarch64/mpegvideoencdsp_neon.S | 67 +++++++++++++++++++++++
> libavcodec/mpegvideoencdsp.c              |  4 +-
> libavcodec/mpegvideoencdsp.h              |  2 +
> 5 files changed, 113 insertions(+), 1 deletion(-)
> create mode 100644 libavcodec/aarch64/mpegvideoencdsp_init.c
> create mode 100644 libavcodec/aarch64/mpegvideoencdsp_neon.S
>
>diff --git a/libavcodec/aarch64/Makefile b/libavcodec/aarch64/Makefile
>index a3256bb1cc..de0653ebbc 100644
>--- a/libavcodec/aarch64/Makefile
>+++ b/libavcodec/aarch64/Makefile
>@@ -10,6 +10,7 @@ OBJS-$(CONFIG_HPELDSP)                  += aarch64/hpeldsp_init_aarch64.o
> OBJS-$(CONFIG_IDCTDSP)                  += aarch64/idctdsp_init_aarch64.o
> OBJS-$(CONFIG_ME_CMP)                   += aarch64/me_cmp_init_aarch64.o
> OBJS-$(CONFIG_MPEGAUDIODSP)             += aarch64/mpegaudiodsp_init.o
>+OBJS-$(CONFIG_MPEGVIDEOENC)             += aarch64/mpegvideoencdsp_init.o
> OBJS-$(CONFIG_NEON_CLOBBER_TEST)        += aarch64/neontest.o
> OBJS-$(CONFIG_PIXBLOCKDSP)              += aarch64/pixblockdsp_init_aarch64.o
> OBJS-$(CONFIG_VIDEODSP)                 += aarch64/videodsp_init.o
>@@ -51,6 +52,7 @@ NEON-OBJS-$(CONFIG_IDCTDSP)             += aarch64/idctdsp_neon.o              \
>                                            aarch64/simple_idct_neon.o
> NEON-OBJS-$(CONFIG_ME_CMP)              += aarch64/me_cmp_neon.o
> NEON-OBJS-$(CONFIG_MPEGAUDIODSP)        += aarch64/mpegaudiodsp_neon.o
>+NEON-OBJS-$(CONFIG_MPEGVIDEOENC)        += aarch64/mpegvideoencdsp_neon.o
> NEON-OBJS-$(CONFIG_PIXBLOCKDSP)         += aarch64/pixblockdsp_neon.o
> NEON-OBJS-$(CONFIG_VC1DSP)              += aarch64/vc1dsp_neon.o
> NEON-OBJS-$(CONFIG_VP8DSP)              += aarch64/vp8dsp_neon.o
>diff --git a/libavcodec/aarch64/mpegvideoencdsp_init.c b/libavcodec/aarch64/mpegvideoencdsp_init.c
>new file mode 100644
>index 0000000000..7eb632ed1b
>--- /dev/null
>+++ b/libavcodec/aarch64/mpegvideoencdsp_init.c
>@@ -0,0 +1,39 @@
>+/*
>+ * This file is part of FFmpeg.
>+ *
>+ * FFmpeg is free software; you can redistribute it and/or
>+ * modify it under the terms of the GNU Lesser General Public
>+ * License as published by the Free Software Foundation; either
>+ * version 2.1 of the License, or (at your option) any later version.
>+ *
>+ * FFmpeg is distributed in the hope that it will be useful,
>+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
>+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>+ * Lesser General Public License for more details.
>+ *
>+ * You should have received a copy of the GNU Lesser General Public
>+ * License along with FFmpeg; if not, write to the Free Software
>+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>+ */
>+
>+#include <stddef.h>
>+#include <stdint.h>
>+
>+#include "libavutil/attributes.h"
>+#include "libavutil/aarch64/cpu.h"
>+#include "libavcodec/mpegvideoencdsp.h"
>+#include "config.h"
>+
>+int ff_pix_sum16_neon(const uint8_t *pix, int line_size);
>+int ff_pix_norm1_neon(const uint8_t *pix, int line_size);
>+
>+av_cold void ff_mpegvideoencdsp_init_aarch64(MpegvideoEncDSPContext *c,
>+                                             AVCodecContext *avctx)
>+{
>+    int cpu_flags = av_get_cpu_flags();
>+
>+    if (have_neon(cpu_flags)) {
>+        c->pix_sum   = ff_pix_sum16_neon;
>+        c->pix_norm1 = ff_pix_norm1_neon;
>+    }
>+}
>diff --git a/libavcodec/aarch64/mpegvideoencdsp_neon.S b/libavcodec/aarch64/mpegvideoencdsp_neon.S
>new file mode 100644
>index 0000000000..89e50e29b3
>--- /dev/null
>+++ b/libavcodec/aarch64/mpegvideoencdsp_neon.S
>@@ -0,0 +1,67 @@
>+/*
>+ * Copyright (c) 2024 Ramiro Polla
>+ *
>+ * This file is part of FFmpeg.
>+ *
>+ * FFmpeg is free software; you can redistribute it and/or
>+ * modify it under the terms of the GNU Lesser General Public
>+ * License as published by the Free Software Foundation; either
>+ * version 2.1 of the License, or (at your option) any later version.
>+ *
>+ * FFmpeg is distributed in the hope that it will be useful,
>+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
>+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>+ * Lesser General Public License for more details.
>+ *
>+ * You should have received a copy of the GNU Lesser General Public
>+ * License along with FFmpeg; if not, write to the Free Software
>+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>+ */
>+
>+#include "libavutil/aarch64/asm.S"
>+
>+function ff_pix_sum16_neon, export=1
>+// x0  const uint8_t *pix
>+// x1  int line_size
>+
>+        sxtw            x1, w1

Can we fix the scan line size to ptrdiff_t to avoid this? Or is it too difficult to deal with existing optimisations?

>+        movi            v0.16b, #0
>+        mov             w2, #16
>+
>+1:
>+        ld1             { v1.16b }, [x0], x1
>+        subs            w2, w2, #1
>+        uadalp          v0.8h, v1.16b
>+        b.ne            1b
>+
>+        uaddlp          v0.4s, v0.8h
>+        uaddlv          d0, v0.4s
>+        fmov            w0, s0
>+
>+        ret
>+endfunc
>+
>+function ff_pix_norm1_neon, export=1
>+// x0  const uint8_t *pix
>+// x1  int line_size
>+
>+        sxtw            x1, w1
>+        movi            v4.16b, #0
>+        movi            v5.16b, #0
>+        mov             w2, #16
>+
>+1:
>+        ld1             { v1.16b }, [x0], x1
>+        subs            w2, w2, #1
>+        umull           v2.8h, v1.8b,  v1.8b
>+        umull2          v3.8h, v1.16b, v1.16b
>+        uadalp          v4.4s, v2.8h
>+        uadalp          v5.4s, v3.8h
>+        b.ne            1b
>+
>+        add             v0.4s, v4.4s, v5.4s
>+        uaddlv          d0, v0.4s
>+        fmov            w0, s0
>+
>+        ret
>+endfunc
>diff --git a/libavcodec/mpegvideoencdsp.c b/libavcodec/mpegvideoencdsp.c
>index 997d048663..a96f0b6436 100644
>--- a/libavcodec/mpegvideoencdsp.c
>+++ b/libavcodec/mpegvideoencdsp.c
>@@ -245,7 +245,9 @@ av_cold void ff_mpegvideoencdsp_init(MpegvideoEncDSPContext *c,
> 
>     c->draw_edges = draw_edges_8_c;
> 
>-#if ARCH_ARM
>+#if ARCH_AARCH64
>+    ff_mpegvideoencdsp_init_aarch64(c, avctx);
>+#elif ARCH_ARM
>     ff_mpegvideoencdsp_init_arm(c, avctx);
> #elif ARCH_PPC
>     ff_mpegvideoencdsp_init_ppc(c, avctx);
>diff --git a/libavcodec/mpegvideoencdsp.h b/libavcodec/mpegvideoencdsp.h
>index 95084679d9..63dbd39603 100644
>--- a/libavcodec/mpegvideoencdsp.h
>+++ b/libavcodec/mpegvideoencdsp.h
>@@ -46,6 +46,8 @@ typedef struct MpegvideoEncDSPContext {
> 
> void ff_mpegvideoencdsp_init(MpegvideoEncDSPContext *c,
>                              AVCodecContext *avctx);
>+void ff_mpegvideoencdsp_init_aarch64(MpegvideoEncDSPContext *c,
>+                                     AVCodecContext *avctx);
> void ff_mpegvideoencdsp_init_arm(MpegvideoEncDSPContext *c,
>                                  AVCodecContext *avctx);
> void ff_mpegvideoencdsp_init_ppc(MpegvideoEncDSPContext *c,


More information about the ffmpeg-devel mailing list