[FFmpeg-devel] [PATCH] avformat/iamf_parse: Fix return of uninitialized value

[Marvin Scholz]

The ret value here is not yet intialized so the return would return
uninitialized data. What was probably meant to be checked here was the
return value of ffio_read_size, which can return an error.

Introduced in 38bcb3ba7b3424abd772c72f8bdf445d75285e88

Fixes: CID1618758
---
 libavformat/iamf_parse.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavformat/iamf_parse.c b/libavformat/iamf_parse.c
index f13e76b147..8a0003634b 100644
--- a/libavformat/iamf_parse.c
+++ b/libavformat/iamf_parse.c
@@ -98,8 +98,8 @@ static int aac_decoder_config(IAMFCodecConfig *codec_config,
         return AVERROR(ENOMEM);
 
     codec_config->extradata_size = ffio_read_size(pb, codec_config->extradata, left);
-    if (ret < 0)
-        return ret;
+    if (codec_config->extradata_size < 0)
+        return codec_config->extradata_size;
     memset(codec_config->extradata + codec_config->extradata_size, 0,
            AV_INPUT_BUFFER_PADDING_SIZE);
 

base-commit: fa5d3cc65309052402c6e3223d127b930b9e5699
-- 
2.39.3 (Apple Git-146)