[FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_scale: switch to new swscale API

Niklas Haas ffmpeg at haasn.xyz
Fri Dec 6 15:40:06 EET 2024


On Fri, 06 Dec 2024 14:31:43 +0100 Michael Niedermayer <michael at niedermayer.cc> wrote:
> Hi
>
> On Mon, Nov 25, 2024 at 10:11:49AM +0000, Niklas Haas wrote:
> > ffmpeg | branch: master | Niklas Haas <git at haasn.dev> | Fri Jun 28 21:42:23 2024 +0200| [04ce01df0bb2d66e143bcfcea439afc2a1b8d96e] | committer: Niklas Haas
> >
> > avfilter/vf_scale: switch to new swscale API
> >
> > Most logic from this filter has been co-opted into swscale itself,
> > allowing the resulting filter to be substantially simpler as it no
> > longer has to worry about context initialization, interlacing, etc.
> >
> > Sponsored-by: Sovereign Tech Fund
> > Signed-off-by: Niklas Haas <git at haasn.dev>
> >
> > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=04ce01df0bb2d66e143bcfcea439afc2a1b8d96e
> > ---
> >
> >  libavfilter/vf_scale.c | 351 +++++++++++--------------------------------------
> >  1 file changed, 77 insertions(+), 274 deletions(-)
>
> It seems this broke:
>
> ./ffmpeg -i mm-short.mpg -vcodec prores -vframes 3 -bitexact -an prores.mkv
> ./ffplay prores.mkv
>
> [swscaler @ 0x7f76380068c0] Unsupported input (Operation not supported): fmt:yuv422p10le csp:gbr prim:reserved trc:reserved -> fmt:yuv420p csp:bt709 prim:reserved trc:reserved

What is the meaning of AVCOL_*_RESERVED and why should we accept it here?

If you look at e.g. H.273, it clearly reserves these values for future use,
and so IMHO treatind them as invalid inputs is not entirely incorrect.

Could we fix the prores decoder to instead output UNSPECIFIED?

>
> thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> You can kill me, but you cannot change the truth.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list