[FFmpeg-devel] [PATCH v2 1/4] checkasm/sw_scale: add assertion for hscale assumption

Niklas Haas ffmpeg at haasn.xyz
Fri Dec 20 14:54:28 EET 2024


From: Niklas Haas <git at haasn.dev>

This code only checks hcScale. In practice this is not an issue because
the function pointers should always be identical to hyScale for the same
filter size.

Add an assertion just to make sure this assumption never regresses.

Signed-off-by: Niklas Haas <git at haasn.dev>
Sponsored-by: Sovereign Tech Fund
---
 tests/checkasm/sw_scale.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/checkasm/sw_scale.c b/tests/checkasm/sw_scale.c
index 350f2b73d4..3d229775d7 100644
--- a/tests/checkasm/sw_scale.c
+++ b/tests/checkasm/sw_scale.c
@@ -346,6 +346,7 @@ static void check_hscale(void)
                 memcpy(filterAvx2, filter, sizeof(uint16_t) * (SRC_PIXELS * MAX_FILTER_WIDTH + MAX_FILTER_WIDTH));
                 ff_shuffle_filter_coefficients(c, filterPosAvx, width, filterAvx2, sws->dst_w);
 
+                av_assert0(c->hyScale == c->hcScale);
                 if (check_func(c->hcScale, "hscale_%d_to_%d__fs_%d_dstW_%d", c->srcBpc, c->dstBpc + 1, width, sws->dst_w)) {
                     memset(dst0, 0, SRC_PIXELS * sizeof(dst0[0]));
                     memset(dst1, 0, SRC_PIXELS * sizeof(dst1[0]));
-- 
2.47.0



More information about the ffmpeg-devel mailing list