[FFmpeg-devel] [PATCH v2] avcodec/h264: fix stride calculation in slice_table for multi-slice field video deblocking

[Lingyi Kong]

Hi Kieran,

Thank you for your feedback. I have already pushed the code related to the FATE test case, and the corresponding sample file is located at (https://trac.ffmpeg.org/attachment/ticket/11360/slice2_field_aurora4.264).

I do not have the permissions to upload it to the FATE server. Could you please assist in copying it over?

Best regards,
Lingyi
________________________________
From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> on behalf of Kieran Kunhya via ffmpeg-devel <ffmpeg-devel at ffmpeg.org>
Sent: Saturday, December 21, 2024 0:52
To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
Cc: Kieran Kunhya <kieran618 at googlemail.com>
Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/h264: fix stride calculation in slice_table for multi-slice field video deblocking

On Fri, Dec 20, 2024 at 5:20 AM Lingyi Kong <konglingyi at visionular.com> wrote:
>
> fix for https://trac.ffmpeg.org/ticket/11360
>
> Signed-off-by: Lingyi Kong <konglingyi at visionular.com>
> ---
>  libavcodec/h264_mb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/h264_mb.c b/libavcodec/h264_mb.c
> index 4e94136313..6083f7ad84 100644
> --- a/libavcodec/h264_mb.c
> +++ b/libavcodec/h264_mb.c
> @@ -529,7 +529,7 @@ static av_always_inline void xchg_mb_border(const H264Context *h, H264SliceConte
>      }
>
>      if (sl->deblocking_filter == 2) {
> -        deblock_topleft = h->slice_table[sl->mb_xy - 1 - h->mb_stride] == sl->slice_num;
> +        deblock_topleft = h->slice_table[sl->mb_xy - 1 - (h->mb_stride << MB_FIELD(sl))] == sl->slice_num;
>          deblock_top     = sl->top_type;
>      } else {
>          deblock_topleft = (sl->mb_x > 0);
> --
> 2.43.0


Hi Lingyi,

Thank you for your patch. Would it be possible to create a FATE test for this?
https://trac.ffmpeg.org/wiki/FATE/AddingATest

Regards,
Kieran Kunhya
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".