[FFmpeg-devel] [PATCH] fftools/ffmpeg_opt: Fix precedence issue in abs_start_seek calculation

[Gyan Doshi]

On 2024-12-26 05:09 am, Pradeep Kumar Goudagunta wrote:
> This patch corrects a C operator precedence issue in fftools/ffmpeg_opt.c
> where the abs_start_seek calculation did not yield the expected result
> due to incorrect placement of parentheses.

Yes, addition has higher precedence than the ternary conditional.

LGTM and will apply.

Regards,
Gyan


> ---
>   fftools/ffmpeg_opt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
> index 9bf0c4f0c4..5777c71236 100644
> --- a/fftools/ffmpeg_opt.c
> +++ b/fftools/ffmpeg_opt.c
> @@ -354,7 +354,7 @@ static void correct_input_start_times(void)
>               if (copy_ts && start_at_zero)
>                   ifile->ts_offset = -new_start_time;
>               else if (!copy_ts) {
> -                abs_start_seek = is->start_time + (ifile->start_time != AV_NOPTS_VALUE) ? ifile->start_time : 0;
> +                abs_start_seek = is->start_time + ((ifile->start_time != AV_NOPTS_VALUE) ? ifile->start_time : 0);
>                   ifile->ts_offset = abs_start_seek > new_start_time ? -abs_start_seek : -new_start_time;
>               } else if (copy_ts)
>                   ifile->ts_offset = 0;