[FFmpeg-devel] [FFmpeg-cvslog] avcodec/libx265: ignore user set alpha x265-param

[James Almer]

On 12/26/2024 3:35 PM, Zhao Zhili wrote:
> 
>> 在 2024年12月27日，上午12:42，James Almer <git at videolan.org> 写道：
>>
>> ffmpeg | branch: master | James Almer <jamrial at gmail.com> | Thu Dec 26 13:41:04 2024 -0300| [7e778586e7efceacae33b12b9b3673838060f8f2] | committer: James Almer
>>
>> avcodec/libx265: ignore user set alpha x265-param
>>
>> It makes no difference when the input has an alpha plane, and may end up in
>> crashes or undefined behavior if it doesn't.
>>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>>
>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=7e778586e7efceacae33b12b9b3673838060f8f2
>> ---
>>
>> libavcodec/cbs_h2645.c |  6 +++---
>> libavcodec/libx265.c   | 16 +++++++++++++++-
>> 2 files changed, 18 insertions(+), 4 deletions(-)
>>
>> diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c
>> index 369e3ac876..647b1c785e 100644
>> --- a/libavcodec/cbs_h2645.c
>> +++ b/libavcodec/cbs_h2645.c
>> @@ -499,9 +499,9 @@ static int cbs_h2645_fragment_add_nals(CodedBitstreamContext *ctx,
>>          size_t size = nal->size;
>>          enum AVCodecID codec_id = ctx->codec->codec_id;
>>
>> -        if (codec_id == AV_CODEC_ID_HEVC && nal->nuh_layer_id > 0 &&
>> -            (nal->type < HEVC_NAL_VPS || nal->type > HEVC_NAL_PPS))
>> -            continue;
>> +//        if (codec_id == AV_CODEC_ID_HEVC && nal->nuh_layer_id > 0 &&
>> +  //          (nal->type < HEVC_NAL_VPS || nal->type > HEVC_NAL_PPS))
>> +    //        continue;
> 
> How this part related to libx265?

It's not. It was accidentally included because of a git -a.

Will revert.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241226/e48bac7b/attachment.sig>