[FFmpeg-devel] [PATCH v2 3/5] hlsenc: Remove bogus check for if (vs->start_pos) for appending segments

Steven Liu lingjiujianke at gmail.com
Wed Jul 3 04:19:30 EEST 2024


Martin Storsjö <martin at martin.st> 于2024年7月3日周三 04:46写道:
>
> On Wed, 26 Jun 2024, Martin Storsjö wrote:
>
> > Previously, vs->start_pos was never 0 here, unless using the
> > -hls_segment_size option, which wasn't allowed for SEGMENT_TYPE_FMP4.
> > Therefore, this if statement was practically always taken anyway.
> >
> > Remove this bogus if statement, to allow changing vs->start_pos
> > to reflect the right value when not using the -hls_segment_size
> > option.
> > ---
> > libavformat/hlsenc.c | 17 ++++++++---------
> > 1 file changed, 8 insertions(+), 9 deletions(-)
>
> Ping Steven, is the second version of this patchset ok? The main
> difference is this patch, which is new.
LGTM


Thanks
Steven


More information about the ffmpeg-devel mailing list