[FFmpeg-devel] [PATCH] avformat/avio: avio_tell() only errors if the context is NULL

Anton Khirnov anton at khirnov.net
Wed Jul 17 09:47:45 EEST 2024


Quoting Michael Niedermayer (2024-07-11 11:49:37)
> Found by code review related to coverity
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavformat/avio.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/avio.h b/libavformat/avio.h
> index ebf611187dc..3be91e4b8a7 100644
> --- a/libavformat/avio.h
> +++ b/libavformat/avio.h
> @@ -489,7 +489,7 @@ int64_t avio_skip(AVIOContext *s, int64_t offset);
>  
>  /**
>   * ftell() equivalent for AVIOContext.
> - * @return position or AVERROR.
> + * @return position or AVERROR in case s is NULL.

It seems weird to document an invalid call.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list