[FFmpeg-devel] [PATCH v2 1/6] lavf/tls_mbedtls: handle more error codes for

[sfan5]

Am 03.06.24 um 22:08 schrieb Jan Ekström:
> On Wed, May 29, 2024 at 2:05 PM sfan5<sfan5 at live.de>  wrote:
> Did an initial tired look at the set, and in general it looks alright
> and the wrapper still builds with Fedora's mbedtls 2.28.8.
>
> (Of course then it fails to link due to unchecked usage of
> `mbedtls_x509_crt_{init,free,parse_file}` in tls_mbedtls, as well as
> `mbedtls_mpi_copy` in rtmpdh. But this breakage is unrelated to this
> patch, as current master does exactly the same)
>
> I'd just probably move the MBEDTLS_ERR_X509_CERT_VERIFY_FAILED logging
> diff into the first commit that adds error codes (also probably
> "messages" in the commit message there?), as adding that error's
> logging really doesn't have anything to do with the verify=0 + TLS 1.3
> workaround.
>
> Jan
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org  with subject "unsubscribe".

I will move that change to the first commit for v3 as discussed on IRC.