[FFmpeg-devel] [PATCH v6 2/2] lavc/dxvenc: migrate DXT1 encoder to lavu hashtable

Michael Niedermayer michael at niedermayer.cc
Wed Jun 5 02:48:39 EEST 2024


On Mon, Jun 03, 2024 at 10:39:04PM -0700, Connor Worley wrote:
> Offers a modest performance gain due to the switch from naive linear
> probling to robin hood.
> 
> Signed-off-by: Connor Worley <connorbworley at gmail.com>
> ---
>  libavcodec/dxvenc.c | 119 ++++++++++++--------------------------------
>  1 file changed, 32 insertions(+), 87 deletions(-)

this seems to break fate

TEST    dxv3enc-dxt1
--- ./tests/ref/fate/dxv3enc-dxt1	2024-06-03 22:55:42.109080592 +0200
+++ tests/data/fate/dxv3enc-dxt1	2024-06-05 01:45:58.899051887 +0200
@@ -3,4 +3,4 @@
 #codec_id 0: dxv
 #dimensions 0: 1920x1080
 #sar 0: 1/1
-0,          0,          0,        1,    76521, 0xed387a5e
+0,          0,          0,        1,    76517, 0xd60c1020
Test dxv3enc-dxt1 failed. Look at tests/data/fate/dxv3enc-dxt1.err for details.
make: *** [tests/Makefile:311: fate-dxv3enc-dxt1] Error 1

thx
[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Never trust a computer, one day, it may think you are the virus. -- Compn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240605/6abc65f8/attachment.sig>


More information about the ffmpeg-devel mailing list