[FFmpeg-devel] [PATCH] avfilter: add sdlvsink for video display

Anton Khirnov anton at khirnov.net
Fri Jun 7 13:46:06 EEST 2024


Quoting Michael Niedermayer (2024-06-07 11:53:51)
> On Fri, Jun 07, 2024 at 09:45:09AM +0300, Rémi Denis-Courmont wrote:
> > Hi,
> > 
> > Le 7 juin 2024 06:33:20 GMT+03:00, Shiqi Zhu <hiccupzhu at gmail.com> a écrit :
> > >> Initialization and render in the same thread is one of the issues. Another
> > >> issue is SDL render should be run in main thread. Maybe it’s not the
> > >> duty of this filter to control which thread to be called, but this wouldn’t
> > >> work with ffmpeg cmd.
> > >>
> > >Yes, I agree with your opinion. The control of the filter should be
> > >left to the application, and the ffmpeg command should only serve the
> > >purpose of demonstrating functionality.
> > 
> > You can't require running on the main thread. There are no ifs or buts here; libavfilter simply can't require that from the calling application or upper-layer framework and therefore it also can't warrant it to SDL.
> 
> We can require anything from an API that we are able to change and extend
> Of course we can decide not to allow such requirment even if optional
> but we surely _could_ add such a feature if we choose to do so

We cannot do it in a backwards compatible way.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list