[FFmpeg-devel] [PATCH 2/9] avformat/rtsp: use < 0 for error check

Michael Niedermayer michael at niedermayer.cc
Sun Jun 9 02:10:39 EEST 2024


Found while reviewing CID1473532 Uninitialized scalar variable

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavformat/rtsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index db78735c7ae..28c858077ad 100644
--- a/libavformat/rtsp.c
+++ b/libavformat/rtsp.c
@@ -1429,7 +1429,7 @@ retry:
     cur_auth_type = rt->auth_state.auth_type;
     if ((ret = rtsp_send_cmd_with_content_async(s, method, url, header,
                                                 send_content,
-                                                send_content_length)))
+                                                send_content_length)) < 0)
         return ret;
 
     if ((ret = ff_rtsp_read_reply(s, reply, content_ptr, 0, method) ) < 0)
-- 
2.45.2



More information about the ffmpeg-devel mailing list