[FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: Fix leak when using non-encoding option

Anton Khirnov anton at khirnov.net
Tue Jun 11 14:23:02 EEST 2024


Quoting Andreas Rheinhardt (2024-06-11 08:37:59)
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
>  fftools/ffmpeg_mux_init.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c
> index 2ed4171a75..e25c6e7e24 100644
> --- a/fftools/ffmpeg_mux_init.c
> +++ b/fftools/ffmpeg_mux_init.c
> @@ -3146,6 +3146,7 @@ static int validate_enc_avopt(Muxer *mux, const AVDictionary *codec_avopt)
>          if (!(option->flags & AV_OPT_FLAG_ENCODING_PARAM)) {
>              av_log(mux, AV_LOG_ERROR, "Codec AVOption %s (%s) is not an "
>                     "encoding option.\n", e->key, option->help ? option->help : "");
> +            av_dict_free(&unused_opts);
>              return AVERROR(EINVAL);

LGTM

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list