[FFmpeg-devel] [PATCH 1/2] lavu/bswap: remove some inline assembler

Michael Niedermayer michael at niedermayer.cc
Tue Jun 11 16:15:19 EEST 2024


On Fri, Jun 07, 2024 at 09:19:46PM +0300, Rémi Denis-Courmont wrote:
> C code or compiler built-ins are preferable over inline assembler for
> byte-swaps as it allows for better optimisations (e.g. instruction
> scheduling) which would otherwise be impossible.
> 
> As with f64c2e710fa1a7b59753224e717f57c48462076f for x86 and Arm,
> this removes the inline assembler on GCC (and Clang) since we now
> require recent enough compiler versions (this indeed seems to work on
> AArch64).
> ---
>  libavutil/aarch64/bswap.h | 56 ---------------------------------------
>  libavutil/avr32/bswap.h   | 44 ------------------------------
>  libavutil/bswap.h         |  8 +-----
>  libavutil/sh4/bswap.h     | 48 ---------------------------------

As you are writing that this preferrable for better optimisations
Please provide benchmarks (for sh4, avr32)

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240611/c65d6922/attachment.sig>


More information about the ffmpeg-devel mailing list