[FFmpeg-devel] [PATCH 6/9] avcodec/libvpxenc: Cleanup on error

James Zern jzern at google.com
Mon Jun 17 20:10:38 EEST 2024


On Sun, Jun 16, 2024 at 4:09 PM Michael Niedermayer
<michael at niedermayer.cc> wrote:
>
> This or fifo needs to be freed on errors explicitly
> I have not verified that its always safe to call vpx_free() this needs to be checked before applying this
>

It should be safe to call into libvpx whether the encoder init
succeeded or not; av_freep() is most of the rest of the code.

> Fixes: memleak
> Fixes: 68937/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LIBVPX_VP8_fuzzer-4830831016214528
>
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavcodec/libvpxenc.c | 2 ++
>  1 file changed, 2 insertions(+)
>

lgtm.


More information about the ffmpeg-devel mailing list