[FFmpeg-devel] [PATCH 3/5] avcodec/hevc/hevcdec: SPS not set (or cleared) after frame start

[Anton Khirnov]

Quoting Michael Niedermayer (2024-06-26 01:52:30)
> On Tue, Jun 25, 2024 at 11:00:44AM +0200, Anton Khirnov wrote:
> > Quoting Michael Niedermayer (2024-06-24 01:01:35)
> > > Fixes: NULL pointer dereference
> > > Fixes: 69623/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-6549698459009024
> > 
> > seems wrong
> 
> Quite possible, but also your comment seems designed to be unhelpfull
> you leave the reader guessing what issue you saw exactly and why and
> what you think is better.

My comment is designed to be as helpful as your commit message.

"Fixes: NULL pointer dereference" says almost nothing about what
actually goes wrong. It should be impossible to get to that point with
the SPS being unset. Assuming it somehow does happen, the correct fix is
to prevent it from happening, not add random checks to random places.

-- 
Anton Khirnov