[FFmpeg-devel] [PATCH v2] libswscale/x86/yuv2rgb: Add missing EMMS

Ramiro Polla ramiro.polla at gmail.com
Wed Jun 26 21:55:31 EEST 2024


Hi,

On Wed, Jun 26, 2024 at 8:03 PM Mario Hros <k3x-devel at outlook.com> wrote:
> Previous rewrite from inline assembly into nasm (commit e934194) missed the required EMMS instruction to bring the x87 FPU back into usable state.
> This needs to be done for 8-byte MMX or Extended MMX only.

Sorry I didn't catch this thread earlier. I sent a patch to outright
remove the mmx/mmxext code (thread "swscale/yuv2rgb/x86: remove
mmx/mmxext yuv2rgb functions"):
https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2024-June/329785.html

The C code should be faster in most cases, or have very similar
performance to the mmx/mmxext code. Is this not the case for you?

Ramiro


More information about the ffmpeg-devel mailing list