[FFmpeg-devel] [PATCH 1/6] avformat/oggdec: Check ffio_ensure_seekback()

[Andreas Rheinhardt]

Andreas Rheinhardt:
> Fixes Coverity issue #1492327.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
>  libavformat/oggdec.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/libavformat/oggdec.c b/libavformat/oggdec.c
> index 8ea81e5d45..5339fdd32c 100644
> --- a/libavformat/oggdec.c
> +++ b/libavformat/oggdec.c
> @@ -364,7 +364,9 @@ static int ogg_read_page(AVFormatContext *s, int *sid, int probing)
>      ffio_init_checksum(bc, ff_crc04C11DB7_update, 0x4fa9b05f);
>  
>      /* To rewind if checksum is bad/check magic on switches - this is the max packet size */
> -    ffio_ensure_seekback(bc, MAX_PAGE_SIZE);
> +    ret = ffio_ensure_seekback(bc, MAX_PAGE_SIZE);
> +    if (ret < 0)
> +        return ret;
>      start_pos = avio_tell(bc);
>  
>      version = avio_r8(bc);

Will apply this patchset tomorrow unless there are objections.

- Andreas