[FFmpeg-devel] [PATCH v11 07/14] avcodec/vaapi_encode: extract the init and close function to base layer

[Lynne]

On 25/05/2024 12:30, tong1.wu-at-intel.com at ffmpeg.org wrote:
> From: Tong Wu <tong1.wu at intel.com>
> 
> Related parameters such as device context, frame context are also moved
> to base layer.
> 
> Signed-off-by: Tong Wu <tong1.wu at intel.com>
> ---
>   libavcodec/hw_base_encode.c     | 49 ++++++++++++++++++
>   libavcodec/hw_base_encode.h     | 17 +++++++
>   libavcodec/vaapi_encode.c       | 90 +++++++++++----------------------
>   libavcodec/vaapi_encode.h       | 10 ----
>   libavcodec/vaapi_encode_av1.c   |  2 +-
>   libavcodec/vaapi_encode_h264.c  |  2 +-
>   libavcodec/vaapi_encode_h265.c  |  2 +-
>   libavcodec/vaapi_encode_mjpeg.c |  6 ++-
>   8 files changed, 102 insertions(+), 76 deletions(-)
> 
> diff --git a/libavcodec/hw_base_encode.c b/libavcodec/hw_base_encode.c
> index 16afaa37be..c4789380b6 100644
> --- a/libavcodec/hw_base_encode.c
> +++ b/libavcodec/hw_base_encode.c
> @@ -592,3 +592,52 @@ end:
>   
>       return 0;
>   }
> +
> +int ff_hw_base_encode_init(AVCodecContext *avctx)
> +{
> +    FFHWBaseEncodeContext *ctx = avctx->priv_data;

This is the issue I was talking about, this requires that 
FFHWBaseEncodeContext is always the main context.

Could you change it so everything takes FFHWBaseEncodeContext as an 
argument, rather than AVCodecContext (apart from where the function 
absolutely must read some data from it)?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xA2FEA5F03F034464.asc
Type: application/pgp-keys
Size: 624 bytes
Desc: OpenPGP public key
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240525/82514bd2/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 236 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240525/82514bd2/attachment.sig>