[FFmpeg-devel] [PATCH v3 01/10] channel_layout: add new channel positions supported by xHE-AAC

Anton Khirnov anton at khirnov.net
Mon May 27 11:40:28 EEST 2024


Quoting Lynne via ffmpeg-devel (2024-05-26 23:42:41)
> ...its an enum entry. Do you want a design document and a proposal?
> You could talk to the person who did the research about it, JEEB.
> Why wait at all? There's only you and JEEB that care about channel 
> layouts, you can review it and give it an LGTM. There's no reason to 
> wait for days, that is not how reviewing is supposed to work.

That's exactly how reviewing is supposed to work. Waiting a few days
won't kill anyone and allows more people to comment.

To the contrary I'm quite unhappy with some recent instances of
developers pushing code immediately upon seeing an LGTM, without giving
other people the opportunity to look at it.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list