[FFmpeg-devel] [PATCH v3 01/10] channel_layout: add new channel positions supported by xHE-AAC

[Anton Khirnov]

Quoting Lynne via ffmpeg-devel (2024-05-27 10:54:40)
> On 27/05/2024 10:40, Anton Khirnov wrote:
> > Quoting Lynne via ffmpeg-devel (2024-05-26 23:42:41)
> >> ...its an enum entry. Do you want a design document and a proposal?
> >> You could talk to the person who did the research about it, JEEB.
> >> Why wait at all? There's only you and JEEB that care about channel
> >> layouts, you can review it and give it an LGTM. There's no reason to
> >> wait for days, that is not how reviewing is supposed to work.
> > 
> > That's exactly how reviewing is supposed to work. Waiting a few days
> > won't kill anyone and allows more people to comment.
> > 
> > To the contrary I'm quite unhappy with some recent instances of
> > developers pushing code immediately upon seeing an LGTM, without giving
> > other people the opportunity to look at it.
> 
> I'd understand if it was for generic common code, but if its for code 
> that the one pushing it maintains, I don't see a problem with this, this 
> is how it works in pretty much every project out there.

I do see a problem - just because you maintain the code doesn't mean
you always understand all its aspects better than everyone, not to
mention when reading your own code you tend to see what you meant to
write rather than what you actually wrote. There's always a nontrivial
possibility that someone could have a meaningful review comment, so why
not wait a day or two? There's no harm in it.

-- 
Anton Khirnov