[FFmpeg-devel] [PATCH 2/2] avcodec/diracdec: Mark flush as av_cold

Lynne dev at lynne.ee
Tue May 28 17:22:16 EEST 2024


On 28/05/2024 16:03, Andreas Rheinhardt wrote:
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
>   libavcodec/diracdec.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c
> index 5bf0dcc2db..76209aebba 100644
> --- a/libavcodec/diracdec.c
> +++ b/libavcodec/diracdec.c
> @@ -351,7 +351,7 @@ static int alloc_buffers(DiracContext *s, int stride)
>       return 0;
>   }
>   
> -static void free_sequence_buffers(DiracContext *s)
> +static av_cold void free_sequence_buffers(DiracContext *s)
>   {
>       int i, j, k;
>   
> @@ -413,7 +413,7 @@ static av_cold int dirac_decode_init(AVCodecContext *avctx)
>       return 0;
>   }
>   
> -static void dirac_decode_flush(AVCodecContext *avctx)
> +static av_cold void dirac_decode_flush(AVCodecContext *avctx)
>   {
>       DiracContext *s = avctx->priv_data;
>       free_sequence_buffers(s);

Both patches look good to me.
I'll remember to mark future decoders' flush with av_cold.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xA2FEA5F03F034464.asc
Type: application/pgp-keys
Size: 624 bytes
Desc: OpenPGP public key
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240528/a7141f29/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 236 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240528/a7141f29/attachment.sig>


More information about the ffmpeg-devel mailing list