[FFmpeg-devel] [PATCHv4] checkasm/lpc: test compute_autocorr

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Wed May 29 23:32:53 EEST 2024


Rémi Denis-Courmont:
> Le keskiviikkona 29. toukokuuta 2024, 22.55.13 EEST Andreas Rheinhardt a écrit 
> :
>> It seems to me that the flac encoder can use odd values (namely if the
>> user set an odd frame_size option or if it gets fed an odd number of
>> samples in which case the last frame will have an odd number of samples).
> 
> As noted earlier the C code seems to assume that len is even, and fixing it is 
> outside the scope of this patch.
> 

I never said you should fix it, but you should not claim in your commit
message that the actual code is not used with odd lengths.

- Andreas



More information about the ffmpeg-devel mailing list