[FFmpeg-devel] [PATCH 01/10, v2] avutil: add hwcontext_amf.

Dmitrii Ovchinnikov ovchinnikov.dmitrii at gmail.com
Thu May 30 17:33:23 EEST 2024


>>This seems to have forgotten to actually allocate anything?
I made an empty allocation here, since in fact all allocation
takes place in the decoder.

>>This makes it look like you really wanted to implement map_from,
not transfer_data_from.
These functions were conceived specifically for transferring data
to and from the host memory. Memory mapping functions will probably
be added in the future.
>>libavutil cannot depend on libavformat, that would be circular.
In the new version, I have removed this and some other unnecessary includes.
(https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=11968)

>>Some of these details look like they should be in the public
hwcontext so that a user can create one.
In the new version, I removed the additional class and put the
functions that the user might need in the header.
I hope everything is better now.


More information about the ffmpeg-devel mailing list