[FFmpeg-devel] [PATCHv4] checkasm/lpc: test compute_autocorr

Rémi Denis-Courmont remi at remlab.net
Thu May 30 18:56:28 EEST 2024


Le keskiviikkona 29. toukokuuta 2024, 23.52.20 EEST James Almer a écrit :
> On 5/29/2024 4:42 PM, Rém
> >   void checkasm_check_lpc(void)
> >   {
> >   
> >       LPCContext ctx;
> > 
> > -    int len = rnd() % 5000;
> > +    int len = 2000 + (rnd() % 1500) * 2;
> 
> Instead of changing how len is generated, which will break known
> existing results for specific seeds in other tests, alter the value when
> passing it to test_compute_autocorr(), like
> apply_welch_window_{even,odd}() do.

Existing benchmarks are unstable and unreliable because of the varying length. 
This was supposed to be contained by the 2000 minimum, but that means the 
benchmarks are invalidated regardless of the parity change.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/





More information about the ffmpeg-devel mailing list